steveloughran commented on issue #1766: HADOOP-16767 Handle non-IO exceptions in reopen() URL: https://github.com/apache/hadoop/pull/1766#issuecomment-570237105 makes sense, patch LGTM and I don't see how you'd easily write a test for it. one little bit of homework: were did you run the hadoop-aws tests against? https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/testing.html#Policy_for_submitting_patches_which_affect_the_hadoop-aws_module. sorry, but even for something trivial we have that due diligence check to stop anything getting in which causes a break.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
