steveloughran commented on a change in pull request #1792: HADOOP-16790: Add
Write Convenience Methods
URL: https://github.com/apache/hadoop/pull/1792#discussion_r363252650
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
##########
@@ -1493,6 +1495,73 @@ public void testReadSymlinkWithAFileAsInput() throws
IOException {
file.delete();
}
+ /**
+ * Test that bytes are written out correctly to the local file system.
+ */
+ @Test
+ public void testWriteBytes() throws IOException {
+ setupDirs();
+
+ URI uri = tmp.toURI();
+ Configuration conf = new Configuration();
+ FileSystem fs = FileSystem.newInstance(uri, conf);
+ Path testPath = new Path(new Path(uri), "writebytes.out");
+
+ byte[] write = new byte[] {0x00, 0x01, 0x02, 0x03};
+
+ FileUtil.write(fs, testPath, write);
+
+ byte[] read = FileUtils.readFileToByteArray(new File(testPath.toUri()));
+
+ assertArrayEquals(write, read);
+ }
+
+ /**
+ * Test that a Collection of Strings are written out correctly to the local
+ * file system.
+ */
+ @Test
+ public void testWriteStrings() throws IOException {
+ setupDirs();
+
+ URI uri = tmp.toURI();
+ Configuration conf = new Configuration();
+ FileSystem fs = FileSystem.newInstance(uri, conf);
+ Path testPath = new Path(new Path(uri), "writestrings.out");
+
+ Collection<String> write = Arrays.asList("over", "the", "lazy", "dog");
+
+ FileUtil.write(fs, testPath, write, StandardCharsets.UTF_8);
+
+ List<String> read =
+ FileUtils.readLines(new File(testPath.toUri()),
StandardCharsets.UTF_8);
+
+ assertEquals(write, read);
Review comment:
I'd consider some round trip tests with ContractTestUtils too, to verify
interop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
