aajisaka commented on a change in pull request #1797: HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… URL: https://github.com/apache/hadoop/pull/1797#discussion_r364028041
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java ########## @@ -406,14 +407,14 @@ public void testLeaseRenewSocketTimeout() throws Exception // throws SocketTimeoutException. Mockito.doNothing().when(spyNN).renewLease( Mockito.anyString()); - leaseRenewer = client.getLeaseRenewer(); - leaseRenewer.setRenewalTime(100); + LeaseRenewer leaseRenewer2 = client.getLeaseRenewer(); Review comment: Should we set final to leaseRenewer2 as well as leaseRenewer1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org