lukmajercak commented on a change in pull request #1825: HDFS-15151 Use 
TransmitFile for file to socket data transfer
URL: https://github.com/apache/hadoop/pull/1825#discussion_r373711257
 
 

 ##########
 File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
 ##########
 @@ -819,6 +849,12 @@ public static boolean access(String path, AccessRight 
desiredAccess)
         }
       }
     }
+
+    public static void setConf(Configuration conf) {
 
 Review comment:
   it's not meant to be only for enabling transmitfile, but generally for 
reloading/resetting the configuration

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to