steveloughran commented on a change in pull request #1830: HADOOP-11867: Add
gather API to file system.
URL: https://github.com/apache/hadoop/pull/1830#discussion_r374652156
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/PositionedReadable.java
##########
@@ -85,4 +89,37 @@ void readFully(long position, byte[] buffer, int offset,
int length)
* the read operation completed
*/
void readFully(long position, byte[] buffer) throws IOException;
+
+ /**
+ * What is the smallest reasonable seek?
+ * @return the minimum number of bytes
+ */
+ default int minimumReasonableSeek() {
+ return 4 * 1024;
Review comment:
should really be constants somewhere, even if within this interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
