ThomasMarquardt commented on a change in pull request #1821: HADOOP-16825: 
Checkaccess testcase fix
URL: https://github.com/apache/hadoop/pull/1821#discussion_r375668532
 
 

 ##########
 File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
 ##########
 @@ -946,7 +946,7 @@ public AclStatus getAclStatus(final Path path) throws 
IOException {
   @Override
   public void access(final Path path, final FsAction mode) throws IOException {
     LOG.debug("AzureBlobFileSystem.access path : {}, mode : {}", path, mode);
-    Path qualifiedPath = makeQualified(path);
+    Path qualifiedPath = path == null ? null : makeQualified(path);
 
 Review comment:
   I don’t follow.  What flow are you referring to?  I think you should revert 
this line because null path should result in IllegalArgumentException. Calling 
makeQualified is a standard thing done by all the APIs taking a Path. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to