hadoop-yetus commented on issue #1842: Hadoop 16730: Add Authorizer Interface URL: https://github.com/apache/hadoop/pull/1842#issuecomment-585164063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 21m 20s | trunk passed | | +1 :green_heart: | compile | 0m 26s | trunk passed | | +1 :green_heart: | checkstyle | 0m 20s | trunk passed | | +1 :green_heart: | mvnsite | 0m 32s | trunk passed | | +1 :green_heart: | shadedclient | 16m 31s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 0m 26s | trunk passed | | +0 :ok: | spotbugs | 0m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 0m 52s | trunk passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 28s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | -0 :warning: | checkstyle | 0m 17s | hadoop-tools/hadoop-azure: The patch generated 74 new + 9 unchanged - 0 fixed = 83 total (was 9) | | +1 :green_heart: | mvnsite | 0m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 15m 11s | patch has no errors when building and testing our client artifacts. | | -1 :x: | javadoc | 0m 20s | hadoop-tools_hadoop-azure generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) | | -1 :x: | findbugs | 0m 59s | hadoop-tools/hadoop-azure generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 19s | hadoop-azure in the patch passed. | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 63m 9s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-tools/hadoop-azure | | | Dead store to qualifiedPath in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.getXAttr(Path, String) At AzureBlobFileSystem.java:org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.getXAttr(Path, String) At AzureBlobFileSystem.java:[line 690] | | | Dead store to qualifiedPath in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.setXAttr(Path, String, byte[], EnumSet) At AzureBlobFileSystem.java:org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.setXAttr(Path, String, byte[], EnumSet) At AzureBlobFileSystem.java:[line 655] | | | Redundant nullcheck of authorizer, which is known to be non-null in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.initializeClient(URI, String, String, boolean) Redundant null check at AzureBlobFileSystemStore.java:is known to be non-null in org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.initializeClient(URI, String, String, boolean) Redundant null check at AzureBlobFileSystemStore.java:[line 1151] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.APPEND_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 46] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.CREATEFILE_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 39] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.DELETE_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 38] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.GETACL_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 41] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.GETFILESTATUS_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 42] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.LISTSTATUS_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 37] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.MKDIR_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 40] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.READ_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 47] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.RENAME_DESTINATION_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 30] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.RENAME_SOURCE_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 29] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.SETACL_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 43] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.SETOWNER_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 44] | | | org.apache.hadoop.fs.azurebfs.constants.AbfsAuthorizerConstants.SETPERMISSION_ACTION isn't final but should be At AbfsAuthorizerConstants.java:be At AbfsAuthorizerConstants.java:[line 45] | | | Unused public or protected field:org.apache.hadoop.fs.azurebfs.extensions.AuthorizationResourceResult.authorizerAction In AuthorizationResourceResult.java | | | Unwritten public or protected field:org.apache.hadoop.fs.azurebfs.extensions.AuthorizationResourceResult.authToken At AuthorizationStatus.java:[line 78] | | | Unwritten public or protected field:org.apache.hadoop.fs.azurebfs.extensions.AuthorizationResourceResult.storePathUri At AuthorizationStatus.java:[line 91] | | | org.apache.hadoop.fs.azurebfs.extensions.AuthorizationResult.getAuthResourceResult() may expose internal representation by returning AuthorizationResult.authResourceResult At AuthorizationResult.java:by returning AuthorizationResult.authResourceResult At AuthorizationResult.java:[line 40] | | | org.apache.hadoop.fs.azurebfs.extensions.AuthorizationResult.setAuthResourceResult(AuthorizationResourceResult[]) may expose internal representation by storing an externally mutable object into AuthorizationResult.authResourceResult At AuthorizationResult.java:by storing an externally mutable object into AuthorizationResult.authResourceResult At AuthorizationResult.java:[line 45] | | | Nullcheck of relativePath at line 236 of value previously dereferenced in org.apache.hadoop.fs.azurebfs.services.AbfsClient.listPath(String, boolean, int, String) At AbfsClient.java:236 of value previously dereferenced in org.apache.hadoop.fs.azurebfs.services.AbfsClient.listPath(String, boolean, int, String) At AbfsClient.java:[line 224] | | | Nullcheck of AbfsClient.authorizer at line 220 of value previously dereferenced in org.apache.hadoop.fs.azurebfs.services.AbfsClient.listPath(String, boolean, int, String) At AbfsClient.java:220 of value previously dereferenced in org.apache.hadoop.fs.azurebfs.services.AbfsClient.listPath(String, boolean, int, String) At AbfsClient.java:[line 215] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1842 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux d1f540ccd624 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 9709afe | | Default Java | 1.8.0_242 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt | | javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-azure.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/testReport/ | | Max. process+thread count | 305 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1842/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
