snvijaya commented on a change in pull request #1842: HADOOP-16730 : ABFS: Add
Authorizer Interface
URL: https://github.com/apache/hadoop/pull/1842#discussion_r379624778
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -1131,20 +1142,38 @@ private void initializeClient(URI uri, String
fileSystemName, String accountName
SharedKeyCredentials creds = null;
AccessTokenProvider tokenProvider = null;
- if (abfsConfiguration.getAuthType(accountName) == AuthType.SharedKey) {
- LOG.trace("Fetching SharedKey credentials");
- int dotIndex = accountName.indexOf(AbfsHttpConstants.DOT);
- if (dotIndex <= 0) {
- throw new InvalidUriException(
- uri.toString() + " - account name is not fully qualified.");
- }
- creds = new SharedKeyCredentials(accountName.substring(0, dotIndex),
+ AuthType authType = abfsConfiguration.getAuthType(accountName);
+ AbfsAuthorizer authorizer = abfsConfiguration.getAbfsAuthorizer();
+
+ // Create cred instance based on account level Auth config if
+ // - authorizer is not configured
+ // - or authroizer configured will not provide SAS
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
