liuml07 commented on a change in pull request #1840: HADOOP-16853.
ITestS3GuardOutOfBandOperations failing on versioned S3 buckets
URL: https://github.com/apache/hadoop/pull/1840#discussion_r380862271
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3GuardOutOfBandOperations.java
##########
@@ -1032,8 +1034,26 @@ private void expectExceptionWhenReading(Path
testFilePath, String text)
private void expectExceptionWhenReadingOpenFileAPI(
Path testFilePath, String text, FileStatus status)
throws Exception {
+ expectExceptionWhenReadingOpenFileAPI(guardedFs,
+ testFilePath, text, status);
+ }
+
+ /**
+ * We expect the read to fail with an FNFE: open will be happy.
+ * @param fs filesystem
+ * @param testFilePath path of the test file
+ * @param text the context in the file.
+ * @param status optional status for the withFileStatus operation.
+ * @throws Exception failure other than the FNFE
+ */
+ private void expectExceptionWhenReadingOpenFileAPI(
+ final S3AFileSystem fs,
+ final Path testFilePath
+ , final String text,
Review comment:
nit: the `,` here goes to the end of last line... :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
