ThomasMarquardt commented on a change in pull request #1842: HADOOP-16730 : ABFS: Add Authorizer Interface URL: https://github.com/apache/hadoop/pull/1842#discussion_r384040926
########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsUriQueryBuilder.java ########## @@ -59,6 +64,20 @@ public String toString() { throw new IllegalArgumentException("Query string param is not encode-able: " + entry.getKey() + "=" + entry.getValue()); } } + // append SAS Token + if (sasToken != null) { + sasToken = sasToken.startsWith(AbfsHttpConstants.QUESTION_MARK) + ? sasToken.substring(1) + : sasToken; Review comment: The interface should require that '?' be omitted from the SAS token. Allowing '?' means the plug-in will add it and then driver will remove it every time, which is wasteful. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org