steveloughran commented on a change in pull request #1823: HADOOP-16794 S3
Encryption keys not propagating correctly during copy operation
URL: https://github.com/apache/hadoop/pull/1823#discussion_r384734793
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3ATestBase.java
##########
@@ -159,4 +168,63 @@ protected void assertStatusCode(AWSServiceIOException e,
int code)
throw e;
}
}
+
Review comment:
I think we should actually have this in a new class, say,
EncryptionTestUtils; we can add more as and when needed. I'd have suggested
S3ATestUtils, but that's too much source of cherrypick/merge pain these days,
which is why I'm trying to split work up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
