[ 
https://issues.apache.org/jira/browse/HADOOP-7602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102700#comment-13102700
 ] 

Daryn Sharp commented on HADOOP-7602:
-------------------------------------

Yes, the patch will be a problem for 7510.  As an aside, I believe the null 
check for {{addr.getHostName()}} is a no-op because {{getHostName}} should 
never return null.  It will return the unresolvable hostname.

Reverting {{SecurityUtil}} method in the original patch to return an empty 
string with the authority is null will re-introduce a bug.  I don't remember 
the exact details, but I encountered a case (in hftp?) where a token was being 
created with an empty service and thus useless.

More importantly, I don't see how reverting will fix this problem.  Reverting 
will let {{har:///path}} work, but I think it's still going to fail on 
{{har://hdfs-something/path}} because the fake hostname will not resolve.  
{{addr.getAddress().getHostAddress()}} will blow with a NPE when 
{{getAddress()}} returns null for the unresolvable host.

> wordcount, sort etc on har files fails with NPE
> -----------------------------------------------
>
>                 Key: HADOOP-7602
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7602
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.20.205.0, 0.20.206.0
>            Reporter: John George
>            Assignee: John George
>             Fix For: 0.20.205.0
>
>         Attachments: hadoop-7602.1.patch, hadoop-7602.2.patch, 
> hadoop-7602.3.patch, hadoop-7602.daryns_comment.2.patch, 
> hadoop-7602.daryns_comment.patch, hadoop-7602.patch
>
>
> wordcount, sort etc on har files fails with 
> NPE@createSocketAddr(NetUtils.java:137). 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to