[ 
https://issues.apache.org/jira/browse/HADOOP-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103964#comment-13103964
 ] 

Hadoop QA commented on HADOOP-7630:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12494302/HADOOP-7630-trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    -1 release audit.  The applied patch generated 9 release audit warnings 
(more than the trunk's current 0 warnings).

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/175//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/175//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/175//console

This message is automatically generated.

> hadoop-metrics2.properties should have a property *.period set to a default 
> value foe metrics
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7630
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7630
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>            Reporter: Arpit Gupta
>            Assignee: Eric Yang
>             Fix For: 0.20.205.0, 0.23.0
>
>         Attachments: HADOOP-7630-trunk.patch, HADOOP-7630.patch
>
>
> currently the hadoop-metrics2.properties file does not have a value set for 
> *.period
> This property is useful for metrics to determine when the property will 
> refresh. We should set it to default of 60

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to