steveloughran commented on issue #1948: HADOOP-16986. s3a to not need wildfly 
on the classpath
URL: https://github.com/apache/hadoop/pull/1948#issuecomment-614059053
 
 
   @iwasakims  -nice to see tokyo tested; been playing with stockholm today 
after some reports of trouble with our SDK version, which predates the region.
   
   > should this be in 3.3.0?
   
   I'm thinking: yes, otherwise we will add a new downstream dependency. Which 
should go into the release notes.
   
   I've been playing with this a little bit more, based on Sahil's comments 
about env vars.
   
   Once you take wildfly off the compile CP of hadoop-aws, it isn't picked up 
on the command line in ~/.hadoop-env
   ```
   HADOOP_OPTIONAL_TOOLS="hadoop-aws"
   ```
   and the "hadoop s3guard" command doesn't find it either
   
   so unless you get wildfly into your CP in some other way, you can't use the 
pure openssl binding from the CLI. "default" is fine, just not "openssl"
   
   What to do? I like the resilience we've added here, but worry about whether 
its now overreacting
   
   Maybe we should
   1. reinstate it as a compile dependency (i.e revert the pom change here); 
fix the new tests to cope with the fact it's found (i.e failure fallback isn't 
going to be tested)
   2. declare that it should be on the CP (release notes), but that it isn't 
mandatory
   3. hadoop-cloud-storage has been pulling it in via azure anyway -maybe we 
should add an explicit declaration too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to