[ 
https://issues.apache.org/jira/browse/HADOOP-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125509#comment-17125509
 ] 

Kihwal Lee commented on HADOOP-13867:
-------------------------------------

I just found out this breaks {{LocalFileSystem}}. If the three argument version 
of rename() is called against {{LocalFileSystem}}, it ends up calling 
{{FilterFileSystem}}'s method, which doesn't do the right thing (i.e. the crc 
files are not renamed). This is because {{ChecksumFileSystem}} does not 
override this method.  When this Jira was done, all subclasses of 
{{FilterFileSystem}} should have been checked for this kind of side-effect.

 

> FilterFileSystem should override rename(.., options) to take effect of Rename 
> options called via FilterFileSystem implementations
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13867
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13867
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Major
>             Fix For: 2.9.0, 2.7.4, 3.0.0-alpha2, 2.8.2
>
>         Attachments: HADOOP-13867-01.patch
>
>
> HDFS-8312 Added Rename.TO_TRASH option to add a security check before moving 
> to trash.
> But for FilterFileSystem implementations since this rename(..options) is not 
> overridden, it uses default FileSystem implementation where Rename.TO_TRASH 
> option is not delegated to NameNode.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to