mukund-thakur commented on a change in pull request #2038:
URL: https://github.com/apache/hadoop/pull/2038#discussion_r439283239
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileOperationCost.java
##########
@@ -168,6 +168,65 @@ public void testCostOfListLocatedStatusOnNonEmptyDir()
throws Throwable {
}
}
+ @Test
+ public void testCostOfListFilesOnFile() throws Throwable {
+ describe("Performing listFiles() on a file");
+ Path file = path(getMethodName() + ".txt");
+ S3AFileSystem fs = getFileSystem();
+ touch(fs, file);
+ resetMetricDiffs();
+ fs.listFiles(file, true);
+ if (!fs.hasMetadataStore()) {
+ metadataRequests.assertDiffEquals(1);
+ } else {
+ if (fs.allowAuthoritative(file)) {
+ listRequests.assertDiffEquals(0);
+ } else {
+ listRequests.assertDiffEquals(1);
+ }
+ }
+ }
+
+ @Test
+ public void testCostOfListFilesOnEmptyDir() throws Throwable {
+ describe("Performing listFiles() on an empty dir");
+ Path dir = path(getMethodName());
+ S3AFileSystem fs = getFileSystem();
+ fs.mkdirs(dir);
+ resetMetricDiffs();
+ fs.listFiles(dir, true);
+ if (!fs.hasMetadataStore()) {
+ verifyOperationCount(2, 1);
+ } else {
+ if (fs.allowAuthoritative(dir)) {
+ verifyOperationCount(0, 0);
+ } else {
+ verifyOperationCount(0, 1);
+ }
+ }
+ }
+
+ @Test
+ public void testCostOfListFilesOnNonEmptyDir() throws Throwable {
Review comment:
Done. There are no cost changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
