bhji123 commented on a change in pull request #2082: URL: https://github.com/apache/hadoop/pull/2082#discussion_r442695952
########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ########## @@ -357,7 +367,7 @@ private RetryDecision shouldRetry(final IOException ioe, final int retryCount, // check for the case of cluster unavailable state if (isClusterUnAvailable(nsId)) { // we allow to retry once if cluster is unavailable - if (retryCount == 0) { Review comment: In fact, not all clients are so smart, they may not configred appropriately. When those clients encounter this problem, they complain about router not retry more. ########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java ########## @@ -557,6 +567,19 @@ private Object invoke(String nsId, int retryCount, final Method method, } // retry + try { Review comment: In fact, not all clients are so smart, they may not configred appropriately. When those clients encounter this problem, they complain about router not retry more. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org