GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r442634441
##########
File path: dev-support/docker/Dockerfile
##########
@@ -86,6 +86,15 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
+#######
+# Boost 1.76 (1.65 ships with Bionic)
+#######
+WORKDIR /root/boost-library
+RUN curl -L
https://sourceforge.net/projects/boost/files/boost/1.72.0/boost_1_72_0.tar.bz2/download
> boost_1_72_0.tar.bz2 \
+ && tar --bzip2 -xf boost_1_72_0.tar.bz2
+WORKDIR /root/boost-library/boost_1_72_0
Review comment:
> Is there any specific reason to use the latest version of boost? If
not, the version provided and maintained in Ubuntu Bionic is better.
Yes @aajisaka. As part of the upgrade, I needed to use
boos::asiot::system_executor -
https://github.com/apache/hadoop/pull/2051/commits/4dcc89a170ec5bdb98960c20ba40d8ce05871071#diff-365634cc5fad269ad19308bd99357403R43.
It's available in Boost 1.72 but not in Boost 1.65.
(Also, it saves us from having to upgrade from 1.65 to 1.7x in the future
:grin:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
