steveloughran commented on pull request #1679: URL: https://github.com/apache/hadoop/pull/1679#issuecomment-648147896
and some minor checkstyles ``` ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MultipartUploader.java:103: CompletableFuture<Integer> abortUploadsUnderPath(Path path) throws IOException;: Line is longer than 80 characters (found 81). [LineLength] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MultipartUploaderBuilder.java:31:public interface MultipartUploaderBuilder<S extends MultipartUploader, B extends MultipartUploaderBuilder<S, B>>: Line is longer than 80 characters (found 112). [LineLength] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/AbstractMultipartUploader.java:106: * {@link MultipartUploader#putPart(UploadHandle, int, Path, InputStream, long)}: Line is longer than 80 characters (found 82). [LineLength] ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/FileSystemMultipartUploaderBuilder.java:35: MultipartUploaderBuilderImpl<FileSystemMultipartUploader, FileSystemMultipartUploaderBuilder> {: Line is longer than 80 characters (found 99). [LineLength] ./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractMultipartUploaderTest.java:100: abortUploadQuietly(activeUpload, activeUploadPath);: 'if' child has incorrect indentation level 10, expected level should be 8. [Indentation] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/S3AMultipartUploaderBuilder.java:34: MultipartUploaderBuilderImpl<S3AMultipartUploader, S3AMultipartUploaderBuilder> {: Line is longer than 80 characters (found 85). [LineLength] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/StoreContextBuilder.java:73: public StoreContextBuilder setFsURI(final URI fsURI) {:49: 'fsURI' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/statistics/S3AMultipartUploaderStatisticsImpl.java:1:/*: Missing package-info.java file. [JavadocPackage] ``` the javadoc one is fixed in the iostats s3 side patch ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org