Hexiaoqiao commented on a change in pull request #2240:
URL: https://github.com/apache/hadoop/pull/2240#discussion_r475635387



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
##########
@@ -483,6 +501,12 @@ private void recomputeScheduleCache() {
 
     for (Map.Entry<Object, List<AtomicLong>> entry : callCosts.entrySet()) {
       Object id = entry.getKey();
+      // The priority for service users is always 0
+      if (isServiceUser((String)id)) {

Review comment:
       @tasanuma Thanks for your proposal. I am concerned any corner case here 
if put service users's request to the priority forever rather than flow 
controls. Such as user `hdfs` is one service user, and submit one big job which 
involve massive RPC request to NameNode, other normal users' request may 
postpone serious.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to