smengcl opened a new pull request #2258: URL: https://github.com/apache/hadoop/pull/2258
https://issues.apache.org/jira/browse/HDFS-15539 I initially intended to put the logic in `SnapshotManager#resetSnapshottable`. But later I figured it makes more sense to put the check on the client side instead: 1. Trash is more of a client-side concept. 2. As a result of (1), it is much cleaner to add the check on the client than on the server side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org