[
https://issues.apache.org/jira/browse/HADOOP-15891?focusedWorklogId=477699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477699
]
ASF GitHub Bot logged work on HADOOP-15891:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/20 08:28
Start Date: 02/Sep/20 08:28
Worklog Time Spent: 10m
Work Description: umamaheswararao commented on a change in pull request
#2185:
URL: https://github.com/apache/hadoop/pull/2185#discussion_r481883237
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/RegexMountPointResolvedDstPathReplaceInterceptor.java
##########
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.fs.viewfs;
+
+import java.io.IOException;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
+
+import org.apache.hadoop.classification.InterfaceAudience;
+import org.apache.hadoop.classification.InterfaceStability;
+import org.apache.hadoop.fs.Path;
+
+import static
org.apache.hadoop.fs.viewfs.RegexMountPointInterceptorType.REPLACE_RESOLVED_DST_PATH;
+
+/**
+ * Implementation of RegexMountPointResolvedDstPathReplaceInterceptor.
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Unstable
+class RegexMountPointResolvedDstPathReplaceInterceptor
+ implements RegexMountPointInterceptor {
+
+ private String srcRegexString;
+ private String replaceString;
+ private Pattern srcRegexPattern;
+
+ RegexMountPointResolvedDstPathReplaceInterceptor(String srcRegex,
+ String replaceString) {
+ this.srcRegexString = srcRegex;
+ this.replaceString = replaceString;
+ this.srcRegexPattern = null;
+ }
+
+ public String getSrcRegexString() {
+ return srcRegexString;
+ }
+
+ public String getReplaceString() {
+ return replaceString;
+ }
+
+ public Pattern getSrcRegexPattern() {
+ return srcRegexPattern;
+ }
+
+ @Override
+ public void initialize() throws IOException {
+ try {
+ srcRegexPattern = Pattern.compile(srcRegexString);
+ } catch (PatternSyntaxException ex) {
+ throw new IOException(
+ "Initialize interceptor failed, srcRegx:" + srcRegexString, ex);
+ }
+ }
+
+ /**
+ * Intercept source before resolution.
+ *
+ * @param source
+ * @return
+ */
+ @Override
+ public String interceptSource(String source) {
+ return source;
+ }
+
+ /**
+ * Intercept resolved path, e.g.
+ * Mount point /^(\\w+)/, ${1}.hadoop.net
+ * If incoming path is /user1/home/tmp/job1,
+ * then the resolved path str will be user1.
+ *
+ * @return intercepted string
+ */
+ @Override public String interceptResolvedDestPathStr(
+ String parsedDestPathStr) {
+ Matcher matcher = srcRegexPattern.matcher(parsedDestPathStr);
+ return matcher.replaceAll(replaceString);
+ }
+
+ /**
+ * Intercept remaining path.
+ *
+ * @return intercepted path
+ */
+ @Override public Path interceptRemainingPath(Path remainingPath) {
Review comment:
The splitting of remaining part is kind implementation details I feel.
User may not clearly have idea on that, unless they are very advanced users.
My question was what if we use same API for remaining part also? in ur
example interceptSource((dir1/dir2/dir3/file3)). What will happen here?
Intercepter are just for replacing some pattern with other right. Let me know
if I am missing.
Thanks for your efforts on fixing other comments..
Also please take a look at check-style warnings reported in latest report.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 477699)
Time Spent: 2h 20m (was: 2h 10m)
> Provide Regex Based Mount Point In Inode Tree
> ---------------------------------------------
>
> Key: HADOOP-15891
> URL: https://issues.apache.org/jira/browse/HADOOP-15891
> Project: Hadoop Common
> Issue Type: New Feature
> Components: viewfs
> Reporter: zhenzhao wang
> Assignee: zhenzhao wang
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-15891.015.patch, HDFS-13948.001.patch,
> HDFS-13948.002.patch, HDFS-13948.003.patch, HDFS-13948.004.patch,
> HDFS-13948.005.patch, HDFS-13948.006.patch, HDFS-13948.007.patch,
> HDFS-13948.008.patch, HDFS-13948.009.patch, HDFS-13948.011.patch,
> HDFS-13948.012.patch, HDFS-13948.013.patch, HDFS-13948.014.patch, HDFS-13948_
> Regex Link Type In Mont Table-V0.pdf, HDFS-13948_ Regex Link Type In Mount
> Table-v1.pdf
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This jira is created to support regex based mount point in Inode Tree. We
> noticed that mount point only support fixed target path. However, we might
> have user cases when target needs to refer some fields from source. e.g. We
> might want a mapping of /cluster1/user1 => /cluster1-dc1/user-nn-user1, we
> want to refer `cluster` and `user` field in source to construct target. It's
> impossible to archive this with current link type. Though we could set
> one-to-one mapping, the mount table would become bloated if we have thousands
> of users. Besides, a regex mapping would empower us more flexibility. So we
> are going to build a regex based mount point which target could refer groups
> from src regex mapping.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
