umamaheswararao edited a comment on pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#issuecomment-687277527


   Thanks @steveloughran for review!
   In addition to his comments, I have the following question/comment.
   In practice, I am thinking this lazy initialization will not give us real 
benefit in the following case with MR/YARN.
   In DelegationTokenIssuer#collectDelegationTokens, it will try to get tokens 
from all children.
   
   ```
   // Now collect the tokens from the children.
       final DelegationTokenIssuer[] ancillary =
           issuer.getAdditionalTokenIssuers();
       if (ancillary != null) {
         for (DelegationTokenIssuer subIssuer : ancillary) {
           collectDelegationTokens(subIssuer, renewer, credentials, tokens);
         }
       } 
   ```
   
   I am wondering this call will make all fs to be initialized. That means we 
are not getting this lazy initialization benefit fully. 
   Did you consider this case? 
   Is there a way to avoid this ? MR/YARN team can suggest something if we have 
alternative way to load tokens. 
   CC: @wangdatan  @sunilgovind @rohithsharmaks 
   CC: @xiaoyuyao 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to