umamaheswararao commented on pull request #2185: URL: https://github.com/apache/hadoop/pull/2185#issuecomment-690863729
+1 on the latest patch. Thanks again for your great work @JohnZZGithub Test failures are unrelated. I think we are 3 line crossed for a warning. Looks like it's not worth minor refactor for sake of that unless we do full refactoring of that method. Please file separate issue to refactor into much cleaner with smaller methods. I will proceed to commit the current patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
