steveloughran commented on pull request #2280: URL: https://github.com/apache/hadoop/pull/2280#issuecomment-691930699
This patch is incomplete. Reverted and will create a new one. Issues * cleanup on a multipart fail will tombstone everything; no information at that point as to what is/isn't a dir * delete needs more coverage I think I may want to push this delete/no-delete logic into s3guard -it can do the check rather than relying on the layer above. But: we will need to pass down for each path whether a path is a dir or a file, so that s3guard doesn't do a DDB query on every single path entry to work that out for itself ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org