mukund-thakur commented on pull request #2257: URL: https://github.com/apache/hadoop/pull/2257#issuecomment-696793895
> Surprisingly large mount of merge problems surfacing here, not in the production code but in the tests. A sign of my patches all going near the same code you've worked on. > > I'm going to move the new inner classes in S3ATestUtils out of there and into their own classes in o.a.h.fs.s3a.test; reduces the diff to S3ATestUtils (which is often a source of spurious merge pain), so once isolated, less long term suffering. > > Doing that in #2310 which is a high priority change for me Oh Yes I refactored some methods to S3ATestUtils thinking that would be the right place for them. Isolating them to o.a.h.fs.s3a.test seems a better idea. Sorry for the inconvenience though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
