goiri commented on a change in pull request #2327: URL: https://github.com/apache/hadoop/pull/2327#discussion_r492960484
########## File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallerContext.java ########## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ipc; + +import org.junit.Assert; +import org.junit.Test; + +public class TestCallerContext { + @Test + public void testBuilderAppend() { + CallerContext.Builder builder = new CallerContext.Builder("context1"); + CallerContext context = + builder.append("context2").append("key3", "value3", ":").build(); Review comment: Having to pass the separator for the key value is weird. ########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java ########## @@ -36,6 +36,7 @@ @InterfaceStability.Evolving public final class CallerContext { public static final Charset SIGNATURE_ENCODING = StandardCharsets.UTF_8; + public static final String ITEM_SEPARATOR = "\\$"; Review comment: This was the issue that Daryn was bringing up. I'm not sure if overriding an existing concept is safe. The idea would be to add a new one with the proper key/value semantic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
