[
https://issues.apache.org/jira/browse/HADOOP-16830?focusedWorklogId=490925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490925
]
ASF GitHub Bot logged work on HADOOP-16830:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 13:26
Start Date: 25/Sep/20 13:26
Worklog Time Spent: 10m
Work Description: steveloughran edited a comment on pull request #2323:
URL: https://github.com/apache/hadoop/pull/2323#issuecomment-698303509
findbugs
```
module:hadoop-common-project/hadoop-common
--
| org.apache.hadoop.fs.statistics.IOStatisticsSnapshot's readObject method
is synchronized At IOStatisticsSnapshot.java: At
IOStatisticsSnapshot.java:[lines 241-254]
```
The synchronized was lifted from TreeMap writeObject. When I turn it off
I'll be reasonably confident that findbugs will start complaining about
unsynchronized accesses to field. Let's see. If it blows up then I'll just
disable the check here
checkstyles are on the uses of the now deprecated methods;
```
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[34,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[82,32]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[83,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[24,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CallableSupplier.java:[68,16]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:[436,51]
[deprecation] FAST_UPLOAD in Constants has been deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[829,13]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,6]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java:[1637,25]
[deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[103,18]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/RetryingCollection.java:[121,18]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[33,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[48,32]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[49,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[52,32]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/select/ITestS3SelectMRJob.java:[212,22]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,21]
[deprecation] FunctionsRaisingIOE in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[320,40]
[deprecation] CallableRaisingIOE in FunctionsRaisingIOE has been deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:[324,16]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
[WARNING]
/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-2323/src/hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestDynamoDBMetadataStoreScale.java:[535,13]
[deprecation] WrappedIOException in org.apache.hadoop.fs.impl has been
deprecated
```
In the full s3a patch these are all migrated; in this PR I'm restricting all
changes to hadoop-common, so *will not fixe them in this patch*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 490925)
Time Spent: 4h 50m (was: 4h 40m)
> Add public IOStatistics API
> ---------------------------
>
> Key: HADOOP-16830
> URL: https://issues.apache.org/jira/browse/HADOOP-16830
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs, fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Applications like to collect the statistics which specific operations take,
> by collecting exactly those operations done during the execution of FS API
> calls by their individual worker threads, and returning these to their job
> driver
> * S3A has a statistics API for some streams, but it's a non-standard one;
> Impala &c can't use it
> * FileSystem storage statistics are public, but as they aren't cross-thread,
> they don't aggregate properly
> Proposed
> # A new IOStatistics interface to serve up statistics
> # S3A to implement
> # other stores to follow
> # Pass-through from the usual wrapper classes (FS data input/output streams)
> It's hard to think about how best to offer an API for operation context
> stats, and how to actually implement.
> ThreadLocal isn't enough because the helper threads need to update on the
> thread local value of the instigator
> My Initial PoC doesn't address that issue, but it shows what I'm thinking of
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
