[
https://issues.apache.org/jira/browse/HADOOP-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116978#comment-13116978
]
Uma Maheswara Rao G commented on HADOOP-7695:
---------------------------------------------
One small nit,
i don't prefer printing invocation object reference numbers along with class
names in logs. org.apache.hadoop.io.retry.RetryInvocationHandler@900e24. Here
intention is just to print the class name of RetryInvocationHandler to know
which handler it is.
This comment is not major, you can take decision. :-)
Thanks
Uma
> RPC.stopProxy can throw unintended exception while logging error
> ----------------------------------------------------------------
>
> Key: HADOOP-7695
> URL: https://issues.apache.org/jira/browse/HADOOP-7695
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Fix For: 0.24.0
>
> Attachments: HADOOP-7695.patch
>
>
> {{RPC.stopProxy}} includes the following lines in case of error:
> {code}
> LOG.error("Could not get invocation handler " + invocationHandler +
> " for proxy " + proxy + ", or invocation handler is not
> closeable.");
> {code}
> Trouble is, the {{proxy}} object is usually backed by {{WritableRpcEngine}},
> which will fail in the event {{toString}} is called on one of its proxy
> objects. See HADOOP-7694 for more details on that issue. Until that's
> addressed, we might as well change the log message in {{RPC.stopProxy}} to
> not call {{toString()}} on {{proxy}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
