ferhui commented on a change in pull request #2327:
URL: https://github.com/apache/hadoop/pull/2327#discussion_r497629890
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
##########
@@ -109,11 +113,32 @@ public String toString() {
/** The caller context builder. */
public static final class Builder {
- private final String context;
+ private static final String KEY_VALUE_SEPARATOR = ":";
+ private final String fieldSeparator;
+ private final StringBuilder sb = new StringBuilder();
private byte[] signature;
public Builder(String context) {
- this.context = context;
+ fieldSeparator = HADOOP_CALLER_CONTEXT_SEPARATOR_DEFAULT;
+ if (isValid(context)) {
+ sb.append(context);
+ }
+ }
+
+ public Builder(Configuration conf) {
+ fieldSeparator = conf.get(HADOOP_CALLER_CONTEXT_SEPARATOR_KEY,
+ HADOOP_CALLER_CONTEXT_SEPARATOR_DEFAULT);
+ }
Review comment:
Good catch.
Refactor builder constructor and remove unnecessary type case in test.
Please review, Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
