steveloughran commented on pull request #2323:
URL: https://github.com/apache/hadoop/pull/2323#issuecomment-701491715


   > error. This is solved when I add ".mean" at the end of the DurationTracker 
stat name. The same with Max(".max" has to be added) and Min(".min" has to be 
added) to fetch their values.
   > Was thinking if we could add it to the getter rather than having to append 
with stat name.
   
   I'm a bit reluctant to, as then people would ask about failures next. What 
could be handy would be something in the support class to get all stats for a 
duration (or null), with some struct to contain them all. e.g
   
   `fetchDurationStatistics(IOStatistics, key) -> {count, min, max ,mean, 
failed, failed.min, failed.max, failed.mean)`, and you'd then work off that. 
Seem good? 
   Troublespot: what if only some of the values were found? they'd be null in 
the result. Maybe we'd let you ask for the success/failure stats separately, 
deal with it that way, and have some `boolean isComplete()` probe to check all 
are set


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to