[ https://issues.apache.org/jira/browse/HADOOP-16878?focusedWorklogId=500282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500282 ]
ASF GitHub Bot logged work on HADOOP-16878: ------------------------------------------- Author: ASF GitHub Bot Created on: 13/Oct/20 20:42 Start Date: 13/Oct/20 20:42 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2383: URL: https://github.com/apache/hadoop/pull/2383#issuecomment-707997222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 29m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-3.3 Compile Tests _ | | +0 :ok: | mvndep | 3m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 26m 23s | branch-3.3 passed | | +1 :green_heart: | compile | 15m 26s | branch-3.3 passed | | +1 :green_heart: | checkstyle | 2m 41s | branch-3.3 passed | | +1 :green_heart: | mvnsite | 2m 53s | branch-3.3 passed | | +1 :green_heart: | shadedclient | 20m 59s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 0s | branch-3.3 passed | | +0 :ok: | spotbugs | 3m 5s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 11s | branch-3.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 58s | the patch passed | | +1 :green_heart: | compile | 14m 52s | the patch passed | | +1 :green_heart: | javac | 14m 52s | the patch passed | | +1 :green_heart: | checkstyle | 2m 40s | the patch passed | | +1 :green_heart: | mvnsite | 2m 51s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 14m 34s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 1s | the patch passed | | +1 :green_heart: | findbugs | 5m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 10m 0s | hadoop-common in the patch passed. | | -1 :x: | unit | 118m 59s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 2s | The patch does not generate ASF License warnings. | | | | 282m 50s | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.security.TestGroupsCaching | | | hadoop.hdfs.web.TestWebHDFS | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2383/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2383 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 14d21fe55d04 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / 351b149 | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~16.04-b01 | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2383/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2383/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2383/1/testReport/ | | Max. process+thread count | 3680 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2383/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 500282) Time Spent: 1h 50m (was: 1h 40m) > FileUtil.copy() to throw IOException if the source and destination are the > same > ------------------------------------------------------------------------------- > > Key: HADOOP-16878 > URL: https://issues.apache.org/jira/browse/HADOOP-16878 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 3.3.0 > Reporter: Gabor Bota > Assignee: Gabor Bota > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > Attachments: hdfsTest.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > We encountered an error during a test in our QE when the file destination and > source path were the same. This happened during an ADLS test, and there were > no meaningful error messages, so it was hard to find the root cause of the > failure. > The error we saw was that file size has changed during the copy operation. > The new file creation in the destination - which is the same as the source - > creates a file and sets the file length to zero. After this, getting the > source file will fail because the sile size changed during the operation. > I propose a solution to at least log in error level in the {{FileUtil}} if > the source and destination of the copy operation is the same, so debugging > issues like this will be easier in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org