[
https://issues.apache.org/jira/browse/HADOOP-17319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218794#comment-17218794
]
Akira Ajisaka commented on HADOOP-17319:
----------------------------------------
Thanks [~ahussein] for your comment.
bq. For example we can call it "TestingScope".
VisibleForTesting is very famous inside and outside Apache Hadoop and I think
the name should not be changed for now. If we rename this, it may be surprising
for the contributors.
bq. Otherwise, VisibltForTesting does not bring anything to the table but
loading bunch of irrelevant classes such as GwtCompatible, Documented, ..etc.
Did anyone consider doing that for the hadoop repository?
Now GwtCompatible and Beta annotations are used in
org.apache.hadoop.hdfs.server.datanode.checker.AbstractChecker, so I didn't
consider doing that.
> Update the checkstyle config to ban some guava functions
> --------------------------------------------------------
>
> Key: HADOOP-17319
> URL: https://issues.apache.org/jira/browse/HADOOP-17319
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Akira Ajisaka
> Priority: Major
>
> Some guava functions are banned in HADOOP-17111, HADOOP-17099, and
> HADOOP-17101 via checkstyle, however, the checkstyle configuration does not
> work after HADOOP-17288 because the package names have been changed.
> Originally reported by [~ahussein] in HADOOP-17315.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
