steveloughran commented on pull request #2310: URL: https://github.com/apache/hadoop/pull/2310#issuecomment-714475083
Checkstyle still fussy. What a pain ``` ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:93: "Bulk delete operation failed to delete all objects; failure count = {}",: Line is longer than 80 characters (found 81). [LineLength] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:331: List<KeyPath> undeleted = extractUndeletedKeyPaths(deleteException, qualifier);: Line is longer than 80 characters (found 83). [LineLength] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:360: public final String key;:25: Variable 'key' must be private and have accessor methods. [VisibilityModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:361: public final Path path;:23: Variable 'path' must be private and have accessor methods. [VisibilityModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:362: public final boolean directoryMarker;:26: Variable 'directoryMarker' must be private and have accessor methods. [VisibilityModifier] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:398: if (this == o) { return true; }:22: '{' at column 22 should have line break after. [LeftCurly] ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:399: if (o == null || getClass() != o.getClass()) { return false; }:52: '{' at column 52 should have line break after. [LeftCurly] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java:668: MetricDiff deleteObjectCount = new MetricDiff(roleFS, OBJECT_DELETE_OBJECTS);: Line is longer than 80 characters (found 81). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java:676: deleteObjectCount.assertDiffEquals("Wrong count of objects in delete request",: Line is longer than 80 characters (found 84). [LineLength] ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org