jojochuang commented on a change in pull request #2436:
URL: https://github.com/apache/hadoop/pull/2436#discussion_r520727890
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -2893,7 +2909,7 @@ protected synchronized Properties getProps() {
}
}
}
- return properties;
+ return props;
Review comment:
(I thought I posted a comment here, but somehow it got lost in github
comments)
returning this object isn't necessary, and obviously the callers don't use
the return value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
