[
https://issues.apache.org/jira/browse/HADOOP-17292?focusedWorklogId=513062&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-513062
]
ASF GitHub Bot logged work on HADOOP-17292:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/20 17:57
Start Date: 17/Nov/20 17:57
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#2350:
URL: https://github.com/apache/hadoop/pull/2350#discussion_r525370313
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/lz4/Lz4Decompressor.java
##########
@@ -22,8 +22,9 @@
import java.nio.Buffer;
import java.nio.ByteBuffer;
+import net.jpountz.lz4.LZ4Factory;
+import net.jpountz.lz4.LZ4SafeDecompressor;
Review comment:
yeah, if things are mixed up, best to leave alone -at least for those
files which get lots of changes. For something which rarely sees maintenance,
you can make a stronger case for cleanup. I do it sometimes, but as I also get
to field cherrypick merge pain, I don't go wild on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 513062)
Time Spent: 9h 20m (was: 9h 10m)
> Using lz4-java in Lz4Codec
> --------------------------
>
> Key: HADOOP-17292
> URL: https://issues.apache.org/jira/browse/HADOOP-17292
> Project: Hadoop Common
> Issue Type: New Feature
> Components: common
> Affects Versions: 3.3.0
> Reporter: L. C. Hsieh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 20m
> Remaining Estimate: 0h
>
> In Hadoop, we use native libs for lz4 codec which has several disadvantages:
> It requires native libhadoop to be installed in system LD_LIBRARY_PATH, and
> they have to be installed separately on each node of the clusters, container
> images, or local test environments which adds huge complexities from
> deployment point of view. In some environments, it requires compiling the
> natives from sources which is non-trivial. Also, this approach is platform
> dependent; the binary may not work in different platform, so it requires
> recompilation.
> It requires extra configuration of java.library.path to load the natives, and
> it results higher application deployment and maintenance cost for users.
> Projects such as Spark use [lz4-java|https://github.com/lz4/lz4-java] which
> is JNI-based implementation. It contains native binaries in jar file, and it
> can automatically load the native binaries into JVM from jar without any
> setup. If a native implementation can not be found for a platform, it can
> fallback to pure-java implementation of lz4.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
