sunchao commented on a change in pull request #2578:
URL: https://github.com/apache/hadoop/pull/2578#discussion_r552933336
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java
##########
@@ -690,4 +695,20 @@ public void addCheckAndUpdateOp(long latency) {
public void addUpdateReplicaUnderRecoveryOp(long latency) {
updateReplicaUnderRecoveryOp.add(latency);
}
+
+ public void incrPacketsReceived() {
+ packetsReceived.incr();
+ }
+
+ public void incrPacketsSlowWriteToMirror() {
+ packetsSlowWriteToMirror.incr();
+ }
+
+ public void incrPacketsSlowWriteToDisk() {
+ packetsSlowWriteToDisk.incr();
+ }
+
+ public void incrPacketsSlowWriteOsCache() {
Review comment:
nit: name this to `incrPacketsSlowWriteToOsCache`?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java
##########
@@ -183,6 +183,11 @@
@Metric private MutableRate checkAndUpdateOp;
@Metric private MutableRate updateReplicaUnderRecoveryOp;
+ @Metric MutableCounterLong packetsReceived;
+ @Metric MutableCounterLong packetsSlowWriteToMirror;
+ @Metric MutableCounterLong packetsSlowWriteToDisk;
+ @Metric MutableCounterLong packetsSlowWriteOsCache;
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
