[ 
https://issues.apache.org/jira/browse/HADOOP-17464?focusedWorklogId=533445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533445
 ]

ASF GitHub Bot logged work on HADOOP-17464:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jan/21 14:13
            Start Date: 09/Jan/21 14:13
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on pull request #2611:
URL: https://github.com/apache/hadoop/pull/2611#issuecomment-757229189


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   2m  9s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |   |   0m  0s | [test4tests](test4tests) |  The patch 
appears to include 34 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 11s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  25m 52s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  26m 28s |  |  trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  compile  |  22m  9s |  |  trunk passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +1 :green_heart: |  checkstyle  |   3m  0s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   7m  4s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  27m 28s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 11s |  |  trunk passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | +1 :green_heart: |  javadoc  |   5m 57s |  |  trunk passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | +0 :ok: |  spotbugs  |   7m 22s |  |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 31s |  |  branch/hadoop-project no findbugs 
output file (findbugsXml.xml)  |
   | -0 :warning: |  patch  |   7m 42s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   6m  8s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  25m 35s |  |  the patch passed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04  |
   | -1 :x: |  javac  |  25m 35s | 
[/diff-compile-javac-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt)
 |  root-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 6 new + 2027 unchanged - 5 
fixed = 2033 total (was 2032)  |
   | +1 :green_heart: |  compile  |  19m 31s |  |  the patch passed with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01  |
   | -1 :x: |  javac  |  19m 31s | 
[/diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt)
 |  root-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK 
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 3 new + 1926 
unchanged - 3 fixed = 1929 total (was 1929)  |
   | -0 :warning: |  checkstyle  |   2m 53s | 
[/diff-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-checkstyle-root.txt)
 |  root: The patch generated 5 new + 240 unchanged - 9 fixed = 245 total (was 
249)  |
   | +1 :green_heart: |  mvnsite  |   7m 23s |  |  the patch passed  |
   | -1 :x: |  whitespace  |   0m  0s | 
[/whitespace-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/whitespace-eol.txt)
 |  The patch has 156 line(s) that end in whitespace. Use git apply 
--whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -1 :x: |  whitespace  |   0m  0s | 
[/whitespace-tabs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/whitespace-tabs.txt)
 |  The patch 2 line(s) with tabs.  |
   | +1 :green_heart: |  xml  |   0m  8s |  |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedclient  |  18m 44s |  |  patch has no errors 
when building and testing our client artifacts.  |
   | -1 :x: |  javadoc  |   1m  1s | 
[/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt)
 |  hadoop-common in the patch failed with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.  |
   | -1 :x: |  javadoc  |   0m 31s | 
[/diff-javadoc-javadoc-hadoop-tools_hadoop-compression-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-compression-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt)
 |  hadoop-tools_hadoop-compression-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 
with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 12 new + 0 unchanged 
- 0 fixed = 12 total (was 0)  |
   | -1 :x: |  javadoc  |   1m 56s | 
[/diff-javadoc-javadoc-hadoop-tools-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-javadoc-javadoc-hadoop-tools-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt)
 |  hadoop-tools-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK 
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 12 new + 421 unchanged - 0 
fixed = 433 total (was 421)  |
   | -1 :x: |  javadoc  |   1m 33s | 
[/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt)
 |  
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 6 new 
+ 0 unchanged - 0 fixed = 6 total (was 0)  |
   | -1 :x: |  javadoc  |   0m 29s | 
[/diff-javadoc-javadoc-hadoop-tools_hadoop-compression-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-compression-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt)
 |  
hadoop-tools_hadoop-compression-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 12 new 
+ 0 unchanged - 0 fixed = 12 total (was 0)  |
   | -1 :x: |  javadoc  |   1m 37s | 
[/diff-javadoc-javadoc-hadoop-tools-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/diff-javadoc-javadoc-hadoop-tools-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt)
 |  hadoop-tools-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with 
JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 12 new + 596 
unchanged - 0 fixed = 608 total (was 596)  |
   | +0 :ok: |  findbugs  |   0m 25s |  |  hadoop-project has no data from 
findbugs  |
   | -1 :x: |  findbugs  |   6m  6s | 
[/new-findbugs-hadoop-tools.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/new-findbugs-hadoop-tools.html)
 |  hadoop-tools generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 26s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   9m 14s |  |  hadoop-common in the patch 
passed.  |
   | -1 :x: |  unit  |   2m 23s | 
[/patch-unit-hadoop-tools_hadoop-compression.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/patch-unit-hadoop-tools_hadoop-compression.txt)
 |  hadoop-compression in the patch passed.  |
   | -1 :x: |  unit  |  55m 12s | 
[/patch-unit-hadoop-tools.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/patch-unit-hadoop-tools.txt)
 |  hadoop-tools in the patch passed.  |
   | -1 :x: |  unit  | 123m 14s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | -1 :x: |  unit  |  11m 24s | 
[/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt)
 |  hadoop-mapreduce-client-nativetask in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  1s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 459m 23s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hadoop-tools |
   |  |  org.apache.hadoop.io.compress.lz4.Lz4Compressor.setInput(byte[], int, 
int) may expose internal representation by storing an externally mutable object 
into Lz4Compressor.userBuf  At Lz4Compressor.java:internal representation by 
storing an externally mutable object into Lz4Compressor.userBuf  At 
Lz4Compressor.java:[line 127] |
   |  |  org.apache.hadoop.io.compress.lz4.Lz4Decompressor.setInput(byte[], 
int, int) may expose internal representation by storing an externally mutable 
object into Lz4Decompressor.userBuf  At Lz4Decompressor.java:internal 
representation by storing an externally mutable object into 
Lz4Decompressor.userBuf  At Lz4Decompressor.java:[line 104] |
   |  |  org.apache.hadoop.io.compress.snappy.SnappyCompressor.setInput(byte[], 
int, int) may expose internal representation by storing an externally mutable 
object into SnappyCompressor.userBuf  At SnappyCompressor.java:internal 
representation by storing an externally mutable object into 
SnappyCompressor.userBuf  At SnappyCompressor.java:[line 92] |
   |  |  
org.apache.hadoop.io.compress.snappy.SnappyDecompressor.setInput(byte[], int, 
int) may expose internal representation by storing an externally mutable object 
into SnappyDecompressor.userBuf  At SnappyDecompressor.java:internal 
representation by storing an externally mutable object into 
SnappyDecompressor.userBuf  At SnappyDecompressor.java:[line 92] |
   | Failed junit tests | 
hadoop.io.compress.zstd.TestZStandardCompressorDecompressor |
   |   | hadoop.io.compress.lz4.TestLz4CompressorDecompressor |
   |   | hadoop.io.compress.zstd.TestZStandardCompressorDecompressor |
   |   | hadoop.io.compress.lz4.TestLz4CompressorDecompressor |
   |   | hadoop.tools.dynamometer.TestDynamometerInfra |
   |   | hadoop.hdfs.server.datanode.TestDataNodeMXBean |
   |   | hadoop.hdfs.server.namenode.TestFSImage |
   |   | hadoop.hdfs.TestDistributedFileSystem |
   |   | hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized |
   |   | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys |
   |   | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints |
   |   | hadoop.mapred.nativetask.compresstest.CompressTest |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/2611 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient xml findbugs checkstyle |
   | uname | Linux c98de20a15fa 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 
10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 890f2da6244 |
   | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private 
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/testReport/ |
   | Max. process+thread count | 3144 (vs. ulimit of 5500) |
   | modules | C: hadoop-project hadoop-common-project/hadoop-common 
hadoop-tools/hadoop-compression hadoop-tools hadoop-hdfs-project/hadoop-hdfs 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
 U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2611/1/console |
   | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
   | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 533445)
    Time Spent: 0.5h  (was: 20m)

> Create hadoop-compression module
> --------------------------------
>
>                 Key: HADOOP-17464
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17464
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: L. C. Hsieh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We added lz4-java, snappy-java dependencies to replace native libs. As per 
> the suggestion from the review comments, we better add a hadoop module to 
> have these extra dependencies, to avoid messing up the dependencies of user 
> application.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to