belugabehr commented on a change in pull request #2633:
URL: https://github.com/apache/hadoop/pull/2633#discussion_r561251612
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java
##########
@@ -260,8 +259,7 @@ public void run() {
} catch (InterruptedException ie) {
return;
} catch (Exception ie) {
- action.weakFs.get().LOG.warn("Failed to renew token, action=" + action,
- ie);
+ FileSystem.LOG.warn("Failed to renew token, action=" + action, ie);
Review comment:
Bad practice here. Accessing a static value in a non-static way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
