[ https://issues.apache.org/jira/browse/HADOOP-17483?focusedWorklogId=541812&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541812 ]
ASF GitHub Bot logged work on HADOOP-17483: ------------------------------------------- Author: ASF GitHub Bot Created on: 26/Jan/21 04:22 Start Date: 26/Jan/21 04:22 Worklog Time Spent: 10m Work Description: steveloughran commented on pull request #2637: URL: https://github.com/apache/hadoop/pull/2637#issuecomment-766810458 I was thinking about this a bit more and worrying about "maybe I should leave the switch in but true everywhere and only document in minimal terms" Why so? Because it is doing something unusual: renaming paths. If anyone ever tried to do a distcp from, say, hdfs and there were __magic paths in there, they'd trigger the behaviour. With a switch to turn it off for those operations, at least if someone complains that we are doing bad things. Note: given the hdfs rule that _ is the temp prefix I'm not over-worried, but I just think it may be good to have an emergency way to unwind ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 541812) Time Spent: 1h 40m (was: 1.5h) > magic committer to be enabled for all S3 buckets > ------------------------------------------------ > > Key: HADOOP-17483 > URL: https://issues.apache.org/jira/browse/HADOOP-17483 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.3.0 > Reporter: Steve Loughran > Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > now that S3 is consistent, there is no need to disable the magic committer > for safety. > remove option to enable magic committer (fs.s3a.committer.magic.enabled) and > the associated checks/probes through the code. > May want to retain the constants and probes just for completeness/API/CLI > consistency. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org