anoopsjohn commented on a change in pull request #2646:
URL: https://github.com/apache/hadoop/pull/2646#discussion_r570750775
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -634,12 +638,15 @@ public AbfsInputStream openFileForRead(final Path path,
final FileSystem.Statist
// Add statistics for InputStream
return new AbfsInputStream(client, statistics,
relativePath, contentLength,
- populateAbfsInputStreamContext(),
+ populateAbfsInputStreamContext(options),
eTag);
}
}
- private AbfsInputStreamContext populateAbfsInputStreamContext() {
+ private AbfsInputStreamContext populateAbfsInputStreamContext(
+ Optional<Configuration> options) {
+ boolean bufferedPreadDisabled = options.isPresent()
Review comment:
Its Configuration in Optional and we need fetch the boolean config out
of that.
So if use orElse() we will end up
Configuration conf = options.orElse();
boolean bufferedPreadDisabled = conf != null &&
conf.getBoolean(FS_AZURE_BUFFERED_PREAD_DISABLE, false);
Otherwise
boolean bufferedPreadDisabled = options.orElseGet(()->{return new
Configuration(false);}).getBoolean("key", false);
Not sure why we should end up creating a new Conf object.
I feel like its better to have current way of hasPresent() check.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
