steveloughran commented on a change in pull request #2646:
URL: https://github.com/apache/hadoop/pull/2646#discussion_r572178766
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java
##########
@@ -634,12 +638,15 @@ public AbfsInputStream openFileForRead(final Path path,
final FileSystem.Statist
// Add statistics for InputStream
return new AbfsInputStream(client, statistics,
relativePath, contentLength,
- populateAbfsInputStreamContext(),
+ populateAbfsInputStreamContext(options),
eTag);
}
}
- private AbfsInputStreamContext populateAbfsInputStreamContext() {
+ private AbfsInputStreamContext populateAbfsInputStreamContext(
+ Optional<Configuration> options) {
+ boolean bufferedPreadDisabled = options.isPresent()
Review comment:
I just had in my head
```
boolean bufferedPreadDisabled = options.map(c ->
c.getBoolean(FS_AZURE_BUFFERED_PREAD_DISABLE, false).orElse(false);
```
See? Functional all the way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
