tomscut commented on a change in pull request #2676:
URL: https://github.com/apache/hadoop/pull/2676#discussion_r574258014
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeDiskMetrics.java
##########
@@ -61,11 +61,26 @@
// code, status should not be overridden by daemon thread.
private boolean overrideStatus = true;
- public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs)
{
+ /**
+ * Minimum number of disks to run outlier detection.
+ */
+ private final long minOutlierDetectionDisks;
+ /**
+ * Threshold in milliseconds below which a disk is definitely not slow.
+ */
+ private final long lowThresholdMs;
+
+ public DataNodeDiskMetrics(DataNode dn, long diskOutlierDetectionIntervalMs,
Configuration conf) {
this.dn = dn;
this.detectionInterval = diskOutlierDetectionIntervalMs;
- slowDiskDetector = new OutlierDetector(MIN_OUTLIER_DETECTION_DISKS,
- SLOW_DISK_LOW_THRESHOLD_MS);
Review comment:
If the code is merged, the unused parameters will be removed. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
