[ https://issues.apache.org/jira/browse/HADOOP-16906?focusedWorklogId=551390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-551390 ]
ASF GitHub Bot logged work on HADOOP-16906: ------------------------------------------- Author: ASF GitHub Bot Created on: 11/Feb/21 17:13 Start Date: 11/Feb/21 17:13 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2684: URL: https://github.com/apache/hadoop/pull/2684#issuecomment-777651153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 36s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | | 0m 0s | [test4tests](test4tests) | The patch appears to include 6 new or modified test files. | |||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 14m 2s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 20m 5s | | trunk passed | | +1 :green_heart: | compile | 20m 39s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | compile | 17m 55s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | +1 :green_heart: | checkstyle | 3m 46s | | trunk passed | | +1 :green_heart: | mvnsite | 2m 25s | | trunk passed | | +1 :green_heart: | shadedclient | 19m 48s | | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 1m 39s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 2m 19s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | +0 :ok: | spotbugs | 1m 15s | | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 3m 34s | | trunk passed | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 26s | | the patch passed | | +1 :green_heart: | compile | 19m 53s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javac | 19m 53s | | the patch passed | | +1 :green_heart: | compile | 20m 44s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | +1 :green_heart: | javac | 20m 44s | | the patch passed | | +1 :green_heart: | checkstyle | 4m 29s | | the patch passed | | +1 :green_heart: | mvnsite | 2m 39s | | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 18m 20s | | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 1m 55s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 3m 10s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | +1 :green_heart: | findbugs | 4m 37s | | the patch passed | |||| _ Other Tests _ | | -1 :x: | unit | 33m 15s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2684/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. | | -1 :x: | unit | 61m 36s | [/patch-unit-hadoop-tools_hadoop-aws.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2684/8/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt) | hadoop-aws in the patch passed. | | +1 :green_heart: | asflicense | 0m 55s | | The patch does not generate ASF License warnings. | | | | 279m 44s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.metrics2.source.TestJvmMetrics | | | hadoop.log.TestLogLevel | | | hadoop.fs.s3a.commit.staging.TestStagingDirectoryOutputCommitter | | | hadoop.fs.s3a.commit.staging.TestStagingCommitter | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2684/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2684 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint | | uname | Linux a3305defea5e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 98ca6afd177 | | Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~20.04-b01 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2684/8/testReport/ | | Max. process+thread count | 1377 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2684/8/console | | versions | git=2.25.1 maven=3.6.3 findbugs=4.0.6 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 551390) Time Spent: 5h 20m (was: 5h 10m) > Add some Abortable.abort() interface for streams etc which can be terminated > ---------------------------------------------------------------------------- > > Key: HADOOP-16906 > URL: https://issues.apache.org/jira/browse/HADOOP-16906 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs, fs/azure, fs/s3 > Affects Versions: 3.3.0 > Reporter: Steve Loughran > Assignee: Jungtaek Lim > Priority: Blocker > Labels: pull-request-available > Time Spent: 5h 20m > Remaining Estimate: 0h > > Some IO we want to be able to abort rather than close cleanly, especially if > the inner stream is an HTTP connection which itself supports some abort() > method. For example: uploads to an object where we want to cancel the upload > without close() making an incomplete write visible. > Proposed: Add a generic interface which things like streams can implement > {code} > AbortableIO { > public void abortIO() throws IOE; > } > {code} > +do for s3a output stream. I wouldn't do this a passthrough on > FSDataOutputStream because we need to consider what expectations callers have > of an operation being "aborted" -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org