mpryahin commented on a change in pull request #2701:
URL: https://github.com/apache/hadoop/pull/2701#discussion_r577531913
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/sftp/TestSFTPFileSystem.java
##########
@@ -374,4 +374,13 @@ public void testMkDirs() throws IOException {
assertThat(((SFTPFileSystem)
sftpFs).getConnectionPool().getLiveConnCount(),
is(1));
}
+
+ @Test
+ public void testCloseFileSystemClosesConnectionPool() throws Exception {
+ SFTPFileSystem fs = (SFTPFileSystem) sftpFs;
+ fs.getHomeDirectory();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(1));
+ fs.close();
+ assertThat(fs.getConnectionPool().getLiveConnCount(), is(0));
+ }
Review comment:
exactly, I missed the catch block, thank you! Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
