functioner commented on pull request #2727: URL: https://github.com/apache/hadoop/pull/2727#issuecomment-788507261
> > According to the comment in that test case, it "should not time out because effective rpc-timeout is multiple of ping interval: 1600 (= 800 * (1000 / 800 + 1))", and it doesn't mean that it shouldn't time out. > > The SocketTimeoutException is thrown on `Socket#read` based on the timeout value set by `Socket#setSoTimeout`. It is set to 800(pingInterval) in the test because (pingInterval < rpcTimeout). The SocketTimeoutException is thrown at 800ms first time and swallowed because 800 < rpcTimeout. SocketTimeoutException is thrown again at 1600ms then handled because 1600 > rpcTimeout. Actually, in the code, `rpcTimeout` is 0 by default, and thus won't satisfy line 545: https://github.com/apache/hadoop/blob/7a3bc90b05f257c8ace2f76d74264906f0f7a932/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java#L538-L550 Therefore, it keeps sending PING. It's not because 800 < rpcTimeout or 1600 > rpcTimeout. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
