tomscut commented on pull request #2788: URL: https://github.com/apache/hadoop/pull/2788#issuecomment-803722823
> @tomscut Thanks for the PR. Some minor comments: > > * Maybe `fsn.close()` should be in the finally scope too. > * It is better to verify that `fsn` and `fsImage` are not null before closing them. Thanks @tasanuma for your kind review and suggestions, I fixed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org