[ 
https://issues.apache.org/jira/browse/HADOOP-17511?focusedWorklogId=569620&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569620
 ]

ASF GitHub Bot logged work on HADOOP-17511:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Mar/21 10:11
            Start Date: 22/Mar/21 10:11
    Worklog Time Spent: 10m 
      Work Description: steveloughran commented on pull request #2675:
URL: https://github.com/apache/hadoop/pull/2675#issuecomment-803942971


   will have to rebase. (sighs)
   
   last version removed some of the callback from the AWS SDK related to copy 
as I didn't think it was needed/actually worked. it is. The transfer manager 
initiates its multipart copy in an executor, somehow we need to add the 
relevant trace data there.
   ```
   
   [ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
9.034 s <<< FAILURE! - in 
org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesDiskBlocks
   [ERROR] 
test_100_renameHugeFile(org.apache.hadoop.fs.s3a.scale.ITestS3AHugeFilesDiskBlocks)
  Time elapsed: 1.194 s  <<< ERROR!
   java.nio.file.AccessDeniedException: tests3ascale/disk/hugefile: 
org.apache.hadoop.fs.s3a.audit.AuditFailureException: 49-00000001 unaudited 
operation Executing a request outside an audit span {multipart_upload_started 
'tests3ascale/disk/hugefileRenamed' size=0, mutating=true}
        at 
org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:208)
        at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:119)
        at org.apache.hadoop.fs.s3a.Invoker.lambda$retry$4(Invoker.java:322)
        at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:414)
        at org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:318)
        at org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:293)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.copyFile(S3AFileSystem.java:4100)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.access$1300(S3AFileSystem.java:241)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem$OperationCallbacksImpl.copyFile(S3AFileSystem.java:1943)
        at 
org.apache.hadoop.fs.s3a.impl.RenameOperation.copySourceAndUpdateTracker(RenameOperation.java:636)
        at 
org.apache.hadoop.fs.s3a.impl.RenameOperation.renameFileToDest(RenameOperation.java:364)
        at 
org.apache.hadoop.fs.s3a.impl.RenameOperation.execute(RenameOperation.java:309)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.innerRename(S3AFileSystem.java:1870)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$rename$7(S3AFileSystem.java:1717)
        at 
org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:499)
        at 
org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.trackDuration(IOStatisticsBinding.java:444)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2186)
        at 
org.apache.hadoop.fs.s3a.S3AFileSystem.rename(S3AFileSystem.java:1715)
        at 
org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles.test_100_renameHugeFile(AbstractSTestS3AHugeFiles.java:511)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
        at 
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.lang.Thread.run(Thread.java:748)
   Caused by: org.apache.hadoop.fs.s3a.audit.AuditFailureException: 49-00000001 
unaudited operation Executing a request outside an audit span 
{multipart_upload_started 'tests3ascale/disk/hugefileRenamed' size=0, 
mutating=true}
        at 
org.apache.hadoop.fs.s3a.audit.impl.LoggingAuditor$WarningSpan.beforeExecution(LoggingAuditor.java:386)
        at 
org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager$WrappingAuditSpan.beforeExecution(ActiveAuditManager.java:394)
        at 
org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager.beforeExecution(ActiveAuditManager.java:238)
        at 
org.apache.hadoop.fs.s3a.audit.impl.ActiveAuditManager$SdkRequestHandler.beforeExecution(ActiveAuditManager.java:277)
        at 
com.amazonaws.AmazonWebServiceClient.beforeClientExecution(AmazonWebServiceClient.java:787)
        at 
com.amazonaws.services.s3.AmazonS3Client.initiateMultipartUpload(AmazonS3Client.java:3528)
        at 
com.amazonaws.services.s3.transfer.internal.CopyCallable.initiateMultipartUpload(CopyCallable.java:250)
        at 
com.amazonaws.services.s3.transfer.internal.CopyCallable.copyInParts(CopyCallable.java:168)
        at 
com.amazonaws.services.s3.transfer.internal.CopyCallable.call(CopyCallable.java:130)
        at 
com.amazonaws.services.s3.transfer.internal.CopyMonitor.call(CopyMonitor.java:132)
        at 
com.amazonaws.services.s3.transfer.internal.CopyMonitor.call(CopyMonitor.java:43)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        ... 1 more
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 569620)
    Time Spent: 10h 10m  (was: 10h)

> Add an Audit plugin point for S3A auditing/context
> --------------------------------------------------
>
>                 Key: HADOOP-17511
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17511
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.3.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 10m
>  Remaining Estimate: 0h
>
> Add a way for auditing tools to correlate S3 object calls with Hadoop FS API 
> calls.
> Initially just to log/forward to an auditing service.
> Later: let us attach them as parameters in S3 requests, such as opentrace 
> headeers or (my initial idea: http referrer header -where it will get into 
> the log)
> Challenges
> * ensuring the audit span is created for every public entry point. That will 
> have to include those used in s3guard tools, some defacto public APIs
> * and not re-entered for active spans. s3A code must not call back into the 
> FS API points
> * Propagation across worker threads



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to