[ https://issues.apache.org/jira/browse/HADOOP-17138?focusedWorklogId=570696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570696 ]
ASF GitHub Bot logged work on HADOOP-17138: ------------------------------------------- Author: ASF GitHub Bot Created on: 23/Mar/21 18:29 Start Date: 23/Mar/21 18:29 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2806: URL: https://github.com/apache/hadoop/pull/2806#issuecomment-805132561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 9m 23s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | |||| _ branch-3.2 Compile Tests _ | | +0 :ok: | mvndep | 3m 58s | | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 23m 44s | | branch-3.2 passed | | +1 :green_heart: | compile | 15m 32s | | branch-3.2 passed | | +1 :green_heart: | checkstyle | 2m 32s | | branch-3.2 passed | | +1 :green_heart: | mvnsite | 8m 43s | | branch-3.2 passed | | +1 :green_heart: | javadoc | 5m 57s | | branch-3.2 passed | | -1 :x: | spotbugs | 9m 56s | [/branch-spotbugs-hadoop-yarn-project_hadoop-yarn-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn-warnings.html) | hadoop-yarn-project/hadoop-yarn in branch-3.2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 1m 52s | [/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html) | hadoop-common-project/hadoop-common in branch-3.2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 2m 45s | [/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html) | hadoop-hdfs-project/hadoop-hdfs in branch-3.2 has 4 extant spotbugs warnings. | | -1 :x: | spotbugs | 3m 49s | [/branch-spotbugs-hadoop-mapreduce-project-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-mapreduce-project-warnings.html) | hadoop-mapreduce-project in branch-3.2 has 2 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 45s | [/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-tools_hadoop-sls-warnings.html) | hadoop-tools/hadoop-sls in branch-3.2 has 1 extant spotbugs warnings. | | -1 :x: | spotbugs | 0m 44s | [/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html) | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests in branch-3.2 has 2 extant spotbugs warnings. | | +1 :green_heart: | shadedclient | 12m 41s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 14s | | the patch passed | | +1 :green_heart: | compile | 14m 53s | | the patch passed | | +1 :green_heart: | javac | 14m 53s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 2m 27s | | the patch passed | | +1 :green_heart: | mvnsite | 9m 3s | | the patch passed | | +1 :green_heart: | xml | 0m 3s | | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 5m 57s | | the patch passed | | +1 :green_heart: | spotbugs | 2m 2s | | hadoop-common-project/hadoop-common generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 2m 55s | | hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | spotbugs | 10m 5s | | hadoop-yarn-project/hadoop-yarn generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 0m 54s | | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 4m 0s | | hadoop-mapreduce-project generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | | +1 :green_heart: | spotbugs | 0m 58s | | hadoop-tools/hadoop-sls generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | shadedclient | 13m 9s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | -1 :x: | unit | 15m 41s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch failed. | | -1 :x: | unit | 172m 25s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch failed. | | -1 :x: | unit | 48m 49s | [/patch-unit-hadoop-yarn-project_hadoop-yarn.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn.txt) | hadoop-yarn in the patch failed. | | +1 :green_heart: | unit | 12m 41s | | hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. | | -1 :x: | unit | 20m 10s | [/patch-unit-hadoop-mapreduce-project.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/patch-unit-hadoop-mapreduce-project.txt) | hadoop-mapreduce-project in the patch failed. | | +1 :green_heart: | unit | 11m 8s | | hadoop-sls in the patch passed. | | +1 :green_heart: | asflicense | 1m 5s | | The patch does not generate ASF License warnings. | | | | 463m 50s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.io.compress.snappy.TestSnappyCompressorDecompressor | | | hadoop.io.compress.TestCompressorDecompressor | | | hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized | | | hadoop.yarn.server.webproxy.amfilter.TestAmFilter | | | hadoop.yarn.server.webproxy.TestWebAppProxyServlet | | | hadoop.mapreduce.split.TestJobSplitWriterWithEC | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2806 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml | | uname | Linux cdc60bc9fdaf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.2 / 5a68e20b31a48943a35ee8a19e756f69b3a9bc45 | | Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/testReport/ | | Max. process+thread count | 2590 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests hadoop-mapreduce-project hadoop-tools/hadoop-sls U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2806/1/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 570696) Time Spent: 1h 50m (was: 1h 40m) > Fix spotbugs warnings surfaced after upgrade to 4.0.6 > ----------------------------------------------------- > > Key: HADOOP-17138 > URL: https://issues.apache.org/jira/browse/HADOOP-17138 > Project: Hadoop Common > Issue Type: Bug > Reporter: Masatake Iwasaki > Assignee: Masatake Iwasaki > Priority: Minor > Labels: pull-request-available > Fix For: 3.3.1, 3.4.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Spotbugs 4.0.6 generated additional warnings. > {noformat} > $ find . -name findbugsXml.xml | xargs -n 1 > /opt/spotbugs-4.0.6/bin/convertXmlToText -longBugCodes > M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in > org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String) > At Server.java:[line 3729] > M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in > org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String) > At Server.java:[line 3717] > H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method > org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(Object) > overrides the nullness annotation of parameter $L1 in an incompatible way > At DatasetVolumeChecker.java:[line 322] > H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method > org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(VolumeCheckResult) > overrides the nullness annotation of parameter result in an incompatible way > At DatasetVolumeChecker.java:[lines 358-376] > M D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method > org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$2.onSuccess(Object) > overrides the nullness annotation of parameter result in an incompatible way > At ThrottledAsyncChecker.java:[lines 170-175] > M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L8 in > org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.incrOpCount(FSEditLogOpCodes, > EnumMap, Step, StartupProgress$Counter) At FSEditLogLoader.java:[line 1241] > M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be > non-null but is marked as nullable At LocatedFileStatusFetcher.java:[lines > 380-397] > M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be > non-null but is marked as nullable At LocatedFileStatusFetcher.java:[lines > 291-309] > M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L6 in > org.apache.hadoop.yarn.sls.SLSRunner.increaseQueueAppNum(String) At > SLSRunner.java:[line 816] > H C UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS UMAC: Uncallable method > org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance() > defined in anonymous class At > TestTimelineReaderWebServicesHBaseStorage.java:[line 87] > M D DLS_DEAD_LOCAL_STORE DLS: Dead store to entities in > org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl) > At TestTimelineReaderHBaseDown.java:[line 190] > M V EI_EXPOSE_REP EI: > org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may expose > internal representation by returning CosNInputStream$ReadBuffer.buffer At > CosNInputStream.java:[line 87] > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org