[ https://issues.apache.org/jira/browse/HADOOP-17619?focusedWorklogId=576524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-576524 ]
ASF GitHub Bot logged work on HADOOP-17619: ------------------------------------------- Author: ASF GitHub Bot Created on: 04/Apr/21 05:31 Start Date: 04/Apr/21 05:31 Worklog Time Spent: 10m Work Description: qizhu-lucas commented on a change in pull request #2846: URL: https://github.com/apache/hadoop/pull/2846#discussion_r606750017 ########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java ########## @@ -107,7 +107,7 @@ public boolean equals(final Object that) { * Set a new time for the renewal. * It can only be called when the action is not in the queue or any * collection because the hashCode may change - * @param newTime the new time + * @param delay the renew cycle Review comment: Thanks @ayushtkn for good suggestion, it's more reasonable. Updated this in latest PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 576524) Time Spent: 1h (was: 50m) > Fix DelegationTokenRenewer#updateRenewalTime java doc error. > ------------------------------------------------------------ > > Key: HADOOP-17619 > URL: https://issues.apache.org/jira/browse/HADOOP-17619 > Project: Hadoop Common > Issue Type: Bug > Reporter: Qi Zhu > Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > The param of updateRenewalTime should be the renew cycle, not the new time. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org